From 441e589424ab0151c955aecfce632fc166990cdf Mon Sep 17 00:00:00 2001 From: Sindre Stephansen Date: Mon, 13 Oct 2025 14:57:59 +0200 Subject: [PATCH] Improve parsing of Sparebanken Norge --- src/bank_parsers/sparebanken_norge.py | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/bank_parsers/sparebanken_norge.py b/src/bank_parsers/sparebanken_norge.py index 61739f6..90b3f83 100644 --- a/src/bank_parsers/sparebanken_norge.py +++ b/src/bank_parsers/sparebanken_norge.py @@ -1,6 +1,6 @@ import pandas as pd -from bank_parsers.helpers import parse_norwegian_date, convert_memo +from bank_parsers.helpers import parse_norwegian_date, parse_norwegian_number, convert_memo def parse_sparebanken_norge(data): @@ -12,14 +12,13 @@ def parse_sparebanken_norge(data): for _, row in data.iterrows(): status = row.get('Status') - cleared = status == "Bokført" - reserved = status == "Reservert" - - if not (cleared or reserved): + if pd.isna(status): continue + cleared = status == "Bokført" + if row.get('Valuta') != 'NOK': - raise ValueError(f"Unknown currency {row['Valuta']}") + raise ValueError(f"Unknown currency {row['Valuta']} in row:\n{row}") payee = convert_memo(row.get('Beskrivelse', '')) memo = convert_memo(row.get('Melding/KID/Fakt.nr', '')) @@ -30,8 +29,8 @@ def parse_sparebanken_norge(data): 'Date': parse_norwegian_date(date), 'Payee': payee, 'Memo': memo, - 'Outflow': -float(row['Beløp ut'] or '0'), - 'Inflow': float(row['Beløp inn'] or '0'), + 'Outflow': -parse_norwegian_number(row['Beløp ut']) or 0, + 'Inflow': parse_norwegian_number(row['Beløp inn']) or 0, 'Cleared': cleared, })